Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding loader for CIPI dataset #599
Adding loader for CIPI dataset #599
Changes from 35 commits
6a2d3a3
e59e8e8
ae5099a
ba71105
a529601
720b0fe
5655ca5
356cebc
30ed498
be73c13
b68ee68
e3b2b12
8174859
3a89ca3
88cd13b
bfc96d0
de3cf84
3848816
6c79866
3bec03b
d96941c
79daf9f
bb24659
06553f1
7e04ebc
3bee2c1
3cace66
e1f0c62
eea4350
c3c0ed4
1a0ac05
a9f3404
9241599
d8ba6d0
1f987a5
bbb1a3f
60849f7
8d78f5c
27feb27
a5e5fbe
bacbd2a
bc4ae49
97fb5f7
c6cca0b
bb6a7b8
9273097
491ed2a
6e07a8a
adc5161
0dad936
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 33 in mirdata/datasets/cipi.py
Codecov / codecov/patch
mirdata/datasets/cipi.py#L32-L33
Check warning on line 37 in mirdata/datasets/cipi.py
Codecov / codecov/patch
mirdata/datasets/cipi.py#L37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this message is not well written! Because if a music xml file is not available, load_score will fail and specify which file is missing, but here, you will print the entire list... maybe you could just say something like "Missing MusicXML files. Did you run .download()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @PRamoneda sorry we missed that one. Can you take a look again?