Update lib_test/mirage for Mirage 3.x #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://mirage.io/wiki/mirage2-to-mirage3 was an incredible resource for helping me update this test code. Tested against Mirage 3.0.5 and ocaml-vchan 3.0.0.
hannesm
reviewed
Sep 6, 2017
lib_test/mirage/unikernel.ml
Outdated
| |`Eof -> C.log c "EOF"; OS.Time.sleep 5. | ||
| |`Error _ -> C.log c "ERR"; OS.Time.sleep 5. | ||
| |`Ok buf -> | ||
| | Ok `Eof -> OS.Time.sleep_ns (5.0 *. 1e9 |> Int64.of_float) >>= fun () -> C.log c "EOF" |
There was a problem hiding this comment.
you may be interested in the duration library - Duration.of_sec 5 does exactly that (and is much more readable) -- plus it doesn't use floating point "numbers" \o/
There was a problem hiding this comment.
Ah, yes! A wonderful recommendation. Thanks!
|
Thanks very much for this contribution (and the compliment on the porting guide), @mneilsen ! :) |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Dec 13, 2018
CHANGES: * Modernise build for OCaml 4.04 and port to Dune (mirage/ocaml-vchan#120 @talex5 @avsm) * Upgrade opam metadata files to 2.0 (mirage/ocaml-vchan#120 @avsm @talex5) * Remove mli only module (mirage/ocaml-vchan#114 @rgrinberg @samoht) * Fix deprecation warning on String.create (mirage/ocaml-vchan#112 @samoht) * Make OCaml 4.04 the minimum version (mirage/ocaml-vchan#111 @cfcs @hannesm) * Update test cases for Mirage 3 (mirage/ocaml-vchan#110 @mneilsen)
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Dec 13, 2018
CHANGES: * Modernise build for OCaml 4.04 and port to Dune (mirage/ocaml-vchan#120 @talex5 @avsm) * Upgrade opam metadata files to 2.0 (mirage/ocaml-vchan#120 @avsm @talex5) * Remove mli only module (mirage/ocaml-vchan#114 @rgrinberg @samoht) * Fix deprecation warning on String.create (mirage/ocaml-vchan#112 @samoht) * Make OCaml 4.04 the minimum version (mirage/ocaml-vchan#111 @cfcs @hannesm) * Update test cases for Mirage 3 (mirage/ocaml-vchan#110 @mneilsen)
fdopen
added a commit
to fdopen/opam-repository-mingw
that referenced
this pull request
Dec 18, 2018
CHANGES: * Modernise build for OCaml 4.04 and port to Dune (mirage/ocaml-vchan#120 @talex5 @avsm) * Upgrade opam metadata files to 2.0 (mirage/ocaml-vchan#120 @avsm @talex5) * Remove mli only module (mirage/ocaml-vchan#114 @rgrinberg @samoht) * Fix deprecation warning on String.create (mirage/ocaml-vchan#112 @samoht) * Make OCaml 4.04 the minimum version (mirage/ocaml-vchan#111 @cfcs @hannesm) * Update test cases for Mirage 3 (mirage/ocaml-vchan#110 @mneilsen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mirage.io/wiki/mirage2-to-mirage3 was an incredible resource for
helping me update this test code. Tested against Mirage 3.0.5 and
ocaml-vchan 3.0.0.