Get rid of mli only module #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dune doesn't support them very well and they add no benefits
|
Btw, there's another benefit that we may be able to reap here. The type |
That sounds like a good idea. Could you do that in a new PR? Thanks! |
Closed
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Dec 13, 2018
CHANGES: * Modernise build for OCaml 4.04 and port to Dune (mirage/ocaml-vchan#120 @talex5 @avsm) * Upgrade opam metadata files to 2.0 (mirage/ocaml-vchan#120 @avsm @talex5) * Remove mli only module (mirage/ocaml-vchan#114 @rgrinberg @samoht) * Fix deprecation warning on String.create (mirage/ocaml-vchan#112 @samoht) * Make OCaml 4.04 the minimum version (mirage/ocaml-vchan#111 @cfcs @hannesm) * Update test cases for Mirage 3 (mirage/ocaml-vchan#110 @mneilsen)
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Dec 13, 2018
CHANGES: * Modernise build for OCaml 4.04 and port to Dune (mirage/ocaml-vchan#120 @talex5 @avsm) * Upgrade opam metadata files to 2.0 (mirage/ocaml-vchan#120 @avsm @talex5) * Remove mli only module (mirage/ocaml-vchan#114 @rgrinberg @samoht) * Fix deprecation warning on String.create (mirage/ocaml-vchan#112 @samoht) * Make OCaml 4.04 the minimum version (mirage/ocaml-vchan#111 @cfcs @hannesm) * Update test cases for Mirage 3 (mirage/ocaml-vchan#110 @mneilsen)
fdopen
added a commit
to fdopen/opam-repository-mingw
that referenced
this pull request
Dec 18, 2018
CHANGES: * Modernise build for OCaml 4.04 and port to Dune (mirage/ocaml-vchan#120 @talex5 @avsm) * Upgrade opam metadata files to 2.0 (mirage/ocaml-vchan#120 @avsm @talex5) * Remove mli only module (mirage/ocaml-vchan#114 @rgrinberg @samoht) * Fix deprecation warning on String.create (mirage/ocaml-vchan#112 @samoht) * Make OCaml 4.04 the minimum version (mirage/ocaml-vchan#111 @cfcs @hannesm) * Update test cases for Mirage 3 (mirage/ocaml-vchan#110 @mneilsen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dune doesn't support them very well and they add no benefits