Fix Boost guidelines violations (boostorg#378)

Add copyright notice. Add protection from the min/max macro. Closes boostorg#376
miralshah365 · Aug 9, 2019 · f6c502b · f6c502b
1 parent 9e76b8b
commit f6c502b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/include/boost/gil/extension/numeric/convolve.hpp b/include/boost/gil/extension/numeric/convolve.hpp
@@ -1,5 +1,6 @@
 //
 // Copyright 2005-2007 Adobe Systems Incorporated
+// Copyright 2019 Miral Shah <miralshah2211@gmail.com>
 //
 // Distributed under the Boost Software License, Version 1.0
 // See accompanying file LICENSE_1_0.txt or copy at

diff --git a/include/boost/gil/extension/numeric/kernel.hpp b/include/boost/gil/extension/numeric/kernel.hpp
@@ -1,10 +1,12 @@
 //
 // Copyright 2005-2007 Adobe Systems Incorporated
+// Copyright 2019 Miral Shah <miralshah2211@gmail.com>
 //
 // Distributed under the Boost Software License, Version 1.0
 // See accompanying file LICENSE_1_0.txt or copy at
 // http://www.boost.org/LICENSE_1_0.txt
 //
+
 #ifndef BOOST_GIL_EXTENSION_NUMERIC_KERNEL_HPP
 #define BOOST_GIL_EXTENSION_NUMERIC_KERNEL_HPP
 

diff --git a/include/boost/gil/image_processing/threshold.hpp b/include/boost/gil/image_processing/threshold.hpp
@@ -153,7 +153,7 @@ void threshold_binary(
     //deciding output channel type and creating functor
     using result_channel_t = typename channel_type<DstView>::type;
 
-    result_channel_t max_value = std::numeric_limits<result_channel_t>::max();
+    result_channel_t max_value = (std::numeric_limits<result_channel_t>::max)();
     threshold_binary(src_view, dst_view, threshold_value, max_value, direction);
 }
 
@@ -230,8 +230,8 @@ void otsu_impl(SrcView const& src_view, DstView const& dst_view, threshold_direc
     std::array<std::size_t, 256> histogram{};
     //initial value of min is set to maximum possible value to compare histogram data
     //initial value of max is set to minimum possible value to compare histogram data
-    auto min = std::numeric_limits<source_channel_t>::max(),
-        max = std::numeric_limits<source_channel_t>::min();
+    auto min = (std::numeric_limits<source_channel_t>::max)(),
+        max = (std::numeric_limits<source_channel_t>::min)();
 
     if (sizeof(source_channel_t) > 1 || std::is_signed<source_channel_t>::value)
     {
@@ -445,7 +445,7 @@ void threshold_adaptive
     //deciding output channel type and creating functor
     typedef typename channel_type<DstView>::type result_channel_t;
 
-    result_channel_t max_value = std::numeric_limits<result_channel_t>::max();
+    result_channel_t max_value = (std::numeric_limits<result_channel_t>::max)();
 
     threshold_adaptive(src_view, dst_view, max_value, kernel_size, method, direction, constant);
 }

diff --git a/test/extension/numeric/kernel.cpp b/test/extension/numeric/kernel.cpp
@@ -1,5 +1,6 @@
 //
 // Copyright 2019 Mateusz Loskot <mateusz at loskot dot net>
+// Copyright 2019 Miral Shah <miralshah2211@gmail.com>
 //
 // Distributed under the Boost Software License, Version 1.0
 // See accompanying file LICENSE_1_0.txt or copy at