chore: move tabindex to the root slot of Spinner (microsoft#31056)

miroslavstastny · Apr 16, 2024 · d38059f · d38059f
1 parent 6441cd2
commit d38059f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/change/@fluentui-react-spinner-99434a32-a61d-4fe2-aa49-f82c5f5dc211.json b/change/@fluentui-react-spinner-99434a32-a61d-4fe2-aa49-f82c5f5dc211.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "chore: move tabindex to the root slot of Spinner.",
+  "packageName": "@fluentui/react-spinner",
+  "email": "ololubek@microsoft.com",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/react-components/react-spinner/src/components/Spinner/useSpinner.tsx b/packages/react-components/react-spinner/src/components/Spinner/useSpinner.tsx
@@ -19,7 +19,7 @@ export const useSpinner_unstable = (props: SpinnerProps, ref: React.Ref<HTMLElem
   const { appearance = 'primary', labelPosition = 'after', size = contextSize ?? 'medium', delay = 0 } = props;
   const baseId = useId('spinner');
 
-  const { role = 'progressbar', tabIndex, ...rest } = props;
+  const { role = 'progressbar', ...rest } = props;
   const nativeRoot = slot.always(
     getIntrinsicElementProps(
       'div',
@@ -57,7 +57,6 @@ export const useSpinner_unstable = (props: SpinnerProps, ref: React.Ref<HTMLElem
   });
   const spinnerShortHand = slot.optional(props.spinner, {
     renderByDefault: true,
-    defaultProps: { tabIndex },
     elementType: 'span',
   });
   if (labelShorthand && nativeRoot && !nativeRoot['aria-labelledby']) {