-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(backend): use node16 for moduleResolution #10938
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #10938 +/- ##
============================================
+ Coverage 77.43% 93.93% +16.50%
============================================
Files 907 2 -905
Lines 91356 462 -90894
Branches 6884 59 -6825
============================================
- Hits 70742 434 -70308
+ Misses 20614 28 -20586 |
おあー |
複数の依存関係があるからこっちでメンテナンスするのは面倒そう |
他のライブラリないかしら |
こまこまのこまり |
おごごごご |
private-ipよりipaddr.jsの方を直接使うのも良さそうです(なぜかprivate-ipはipaddr.jsのparserだけ使っていて |
そうするか |
|
(rndstr管理されてないしhttps://www.npmjs.com/package/randomstring 使ってもよさそうですがどうでしょう) |
良さそう |
マージするか |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
よさそう
🙏🙏🙏 |
What
Why
got v13を使うにはそうしないといけないらしい
https://github.com/sindresorhus/got/issues/2267#issuecomment-1565659377
あとnodeは使わない方が良いらしい
https://blog.s2n.tech/articles/dont-use-moduleresolution-node
Additional info (optional)
Checklist