Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): replace private-ip with ipaddr.js #11041

Merged
merged 2 commits into from
Jun 24, 2023
Merged

refactor(backend): replace private-ip with ipaddr.js #11041

merged 2 commits into from
Jun 24, 2023

Conversation

saschanaz
Copy link
Member

What

タイトル通り

Why

#10938 でしゅいろさんがおごごごごしなくてすむように

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jun 24, 2023
@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Merging #11041 (975cc20) into develop (5d922e3) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop   #11041      +/-   ##
===========================================
  Coverage    77.42%   77.43%              
===========================================
  Files          739      907     +168     
  Lines        70493    91359   +20866     
  Branches      6449     6885     +436     
===========================================
+ Hits         54582    70744   +16162     
- Misses       15911    20615    +4704     
Impacted Files Coverage Δ
packages/backend/src/core/DownloadService.ts 70.39% <44.44%> (+0.65%) ⬆️
packages/backend/src/misc/get-ip-hash.ts 78.57% <100.00%> (ø)

... and 169 files with indirect coverage changes

@syuilo syuilo merged commit a2c0573 into develop Jun 24, 2023
@syuilo syuilo deleted the ipaddr branch June 24, 2023 21:35
@syuilo
Copy link
Member

syuilo commented Jun 24, 2023

🙏🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants