Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make shell scripts have consistent indentation of 4 space chars #272

Closed
rockett-m opened this issue Jun 26, 2024 · 1 comment · Fixed by #273
Closed

Make shell scripts have consistent indentation of 4 space chars #272

rockett-m opened this issue Jun 26, 2024 · 1 comment · Fixed by #273

Comments

@rockett-m
Copy link
Contributor

Roughly half the shell scripts use 2 spaces for indents and the rest use 4 spaces.

Our python and c++ code use 4 spaces as the indent, so it would be helpful to enforce this for our shell scripts too
@rockett-m
Copy link
Contributor Author

@HalosGhost happy to tackle this one if you can assign it to me and if you see this proposal as worthwhile.

rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 26, 2024
@rockett-m
made shell scripts all have 4 spaces for indents not 2; issue mit-dci…
8d5a207 
…#272

Signed-off-by: Morgan Rockett <morgan.rockett@tufts.edu>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 26, 2024
@rockett-m
chore: made shell scripts all have 4 spaces for indentation; issue mi…
e43617e 
…t-dci#272

Signed-off-by: Morgan Rockett <morgan.rockett@tufts.edu>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 26, 2024
@rockett-m
style: made shell scripts all have 4 spaces for indentation; issue mi…
9876100 
…t-dci#272

Signed-off-by: Morgan Rockett <morgan.rockett@tufts.edu>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 26, 2024
@rockett-m
style: made shell scripts all have 4 spaces for indentation; issue mi…
dfae673 
…t-dci#272

Signed-off-by: Morgan Rockett <morgan.rockett@tufts.edu>
@HalosGhost HalosGhost linked a pull request Jun 26, 2024 that will close this issue
made shell scripts all have 4 spaces for indents not 2; issue #272 #273
Merged
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 26, 2024
@rockett-m
style: made shell scripts all have 4 spaces for indentation; issue mi…
20acfa1 
…t-dci#272

Signed-off-by: Morgan Rockett <morgan.rockett@tufts.edu>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 26, 2024
@rockett-m
style: made shell scripts all have 4 spaces for indentation; fixes mi…
89200c7 
…t-dci#272

Signed-off-by: Morgan Rockett <morgan.rockett@tufts.edu>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 26, 2024
@rockett-m
style: made shell scripts all have 4 spaces for indentation; fixes mi…
6fcdbca 
…t-dci#272

Signed-off-by: Morgan Rockett <morgan.rockett@tufts.edu>
HalosGhost pushed a commit that referenced this issue Jun 28, 2024
@rockett-m @HalosGhost
style: made shell scripts all have 4 spaces for indentation; fixes #272
d792c5e 
Signed-off-by: Morgan Rockett <morgan.rockett@tufts.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

made shell scripts all have 4 spaces for indents not 2; issue #272 rockett-m/opencbdc-tx
1 participant
@rockett-m