Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made shell scripts all have 4 spaces for indents not 2; issue #272 #273

Merged
merged 1 commit into from
Jun 28, 2024
Merged

made shell scripts all have 4 spaces for indents not 2; issue #272 #273

merged 1 commit into from
Jun 28, 2024

Conversation

rockett-m
Copy link
Contributor

Now all shell scripts have indentation at 4 spaces. Previously it was mixed between 2 and 4 spaces for indents.

@rockett-m rockett-m force-pushed the shell-indents branch 2 times, most recently from e43617e to 9876100 Compare June 26, 2024 13:43
maurermi
maurermi requested changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@maurermi maurermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One requested change -- otherwise I think this is OK assuming we want to enforce 4 spaces instead of 2

scripts/lint.sh Outdated Show resolved Hide resolved
@rockett-m rockett-m requested a review from maurermi June 26, 2024 13:55
@rockett-m rockett-m mentioned this pull request Jun 26, 2024
Merged
@rockett-m
Copy link
Contributor Author

@HalosGhost is this good to merge?

@HalosGhost
Copy link
Collaborator

Additionally, instead of saying issue #the-number, it's much nicer if you say closes #the-number or fixes #the-number in commit messages; GitHub automatically picks those up and and links PRs to issues (closing the issue automatically on-merge). I've manually linked this one.

@HalosGhost HalosGhost linked an issue Jun 26, 2024 that may be closed by this pull request
Make shell scripts have consistent indentation of 4 space chars #272
Closed
@rockett-m rockett-m force-pushed the shell-indents branch 2 times, most recently from 20acfa1 to 89200c7 Compare June 26, 2024 17:02
@rockett-m
style: made shell scripts all have 4 spaces for indentation; fixes mi…
6fcdbca 
…t-dci#272

Signed-off-by: Morgan Rockett <morgan.rockett@tufts.edu>
rockett-m
rockett-m commented Jun 26, 2024
View reviewed changes
Copy link
Contributor Author

@rockett-m rockett-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closing the review, thanks

HalosGhost
HalosGhost approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@HalosGhost HalosGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unifies indentation for shell scripts.

Looks good to me.

@HalosGhost
Copy link
Collaborator

@maurermi when you have a moment; mind double-checking that there's nothing left that you'd want to see changed?

maurermi
maurermi approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@maurermi maurermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, just unifies indentation and makes no significant or concerning changes, looks good to me

@HalosGhost HalosGhost merged commit d792c5e into mit-dci:trunk Jun 28, 2024
6 checks passed
@rockett-m rockett-m deleted the shell-indents branch July 22, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalosGhost HalosGhost HalosGhost approved these changes

@maurermi maurermi maurermi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make shell scripts have consistent indentation of 4 space chars
3 participants
@rockett-m @HalosGhost @maurermi