product page performance tweaks #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umarmughal824
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1927 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 165 165
Lines 9569 9569
Branches 1004 1004
=======================================
Hits 8026 8026
Misses 1309 1309
Partials 234 234 Continue to review full report at Codecov.
|
|
@ahmed-belal there are no |
umarmughal824
force-pushed
the
umar/mitxpro-1920
branch
from
38fe4dc to
ac6a19a
Compare
ahmed-belal
suggested changes
Sep 24, 2020
Comment on lines
-4
to
-9
| src: url("#{$static-path}/fonts/icomoon.eot?dd3z7r"), | ||
| url("#{$static-path}/fonts/icomoon.eot?dd3z7r#iefix") | ||
| format("embedded-opentype"), | ||
| url("#{$static-path}/fonts/icomoon.ttf?dd3z7r") format("truetype"), | ||
| url("#{$static-path}/fonts/icomoon.woff?dd3z7r") format("woff"), | ||
| url("#{$static-path}/fonts/icomoon.svg?dd3z7r#icomoon") format("svg"); |
There was a problem hiding this comment.
This might not fix everything we want to. Refer to the lighthouse report which still flags this as an issue:
The recommended way of fixing it:
https://web.dev/font-display/?utm_source=lighthouse&utm_medium=devtools
There was a problem hiding this comment.
It's done exactly that way and I don't see that error on my side.
umarmughal824
force-pushed
the
umar/mitxpro-1920
branch
from
d75963f to
1a1e00a
Compare
|
Could you be more specific in the commit message about the tweaks that are included here? I see there's some changes to font handling. What else is there? |
ahmed-belal
approved these changes
Sep 29, 2020
@pdpinch there is icomoon font changes and also some changes for best practices in HTML5. |
That's the comment I posted on the slack. There are two possible and suggested ways either preload it or load it with the system default and swap it later once loaded. |
umarmughal824
force-pushed
the
umar/mitxpro-1920
branch
from
1a1e00a to
b78efe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
What are the relevant tickets?
fixes #1920
What's this PR do?
Makes resource usage changes to the product page to partially fix issues described in #1908
How should this be manually tested?
Use Lighthouse or Google Pagespeed to test before/after performance score. There should be an increase in the overall score and speed for the page.
Extras?
Devops needs to increase the cache expiry limit on media resources for xPRO (probably on the CDN level if it's being controlled from there or the server if that's the original source of the cache header).