-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
product page performance tweaks #1927
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,62 +1,80 @@ | ||
| {% load static %} | ||
|
|
||
| <footer class="footer"> | ||
| <div class="footer-top"> | ||
| <div class="container"> | ||
| <div class="content-holder"> | ||
| <div class="row"> | ||
| <div class="col-sm-6 clearfix"> | ||
| <img src={% static 'images/help.png' %}> | ||
| <div class="info"> | ||
| <a href="https://xpro.zendesk.com/hc/"> | ||
| <h2>Help & FAQ</h2> | ||
| </a> | ||
| <p>Find answers to your questions.</p> | ||
| </div> | ||
| </div> | ||
| <div class="col-sm-6 clearfix"> | ||
| <img src={% static 'images/contact.png' %}> | ||
| <div class="info"> | ||
| <a href="https://xpro.zendesk.com/hc/en-us/requests/new"> | ||
| <h2>Contact Us</h2> | ||
| </a> | ||
| <p>Let us know how we can assist you.</p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div class="footer-top"> | ||
| <div class="container"> | ||
| <div class="footer-bottom"> | ||
| <div class="mit-info"> | ||
| <img src="{% static 'images/mit.png' %}" alt="MIT"> | ||
| <address> | ||
| Massachusetts Institute of Technology <br>77 Massachusetts Avenue <br>Cambridge, MA 02139 | ||
| </address> | ||
| <div class="content-holder"> | ||
| <div class="row"> | ||
| <div class="col-sm-6 clearfix"> | ||
| <img src={% static 'images/help.png' %} alt="Help"> | ||
| <div class="info"> | ||
| <a href="https://xpro.zendesk.com/hc/"> | ||
| <h2>Help & FAQ</h2> | ||
| </a> | ||
| <p>Find answers to your questions.</p> | ||
| </div> | ||
| <div class="right-info"> | ||
| <ul class="footer-nav"> | ||
| <li><a href="/about-us/">About Us</a></li> | ||
| </ul> | ||
| <script charset="utf-8" type="text/javascript" src="//js.hsforms.net/forms/v2-legacy.js"></script> | ||
| <script charset="utf-8" type="text/javascript" src="//js.hsforms.net/forms/v2.js"></script> | ||
| <script> | ||
| if (typeof hbspt !== 'undefined') { | ||
| hbspt.forms.create({ | ||
| portalId: '{{ hubspot_portal_id }}', | ||
| formId: '{{ hubspot_footer_form_guid }}' | ||
| }); | ||
| } | ||
| </script> | ||
| </div> | ||
| <div class="col-sm-6 clearfix"> | ||
| <img src={% static 'images/contact.png' %} alt="Contact Us"> | ||
| <div class="info"> | ||
| <a href="https://xpro.zendesk.com/hc/en-us/requests/new"> | ||
| <h2>Contact Us</h2> | ||
| </a> | ||
| <p>Let us know how we can assist you.</p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <ul class="footer-sub-nav"> | ||
| <li><a href="/terms-of-service/">Terms of Service</a></li> | ||
| <li><a href="/privacy-policy/">Privacy Policy</a></li> | ||
| <li><a href="/honor-code/">Honor Code</a></li> | ||
| <li><a target="_blank" href="https://accessibility.mit.edu/">Accessibility</a></li> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div class="container"> | ||
| <div class="footer-bottom"> | ||
| <div class="mit-info"> | ||
| <img src="{% static 'images/mit.png' %}" alt="MIT" /> | ||
| <address> | ||
| Massachusetts Institute of Technology <br />77 Massachusetts Avenue | ||
| <br />Cambridge, MA 02139 | ||
| </address> | ||
| </div> | ||
| <div class="right-info"> | ||
| <ul class="footer-nav"> | ||
| <li><a href="/about-us/">About Us</a></li> | ||
| </ul> | ||
| <span class="copyright">© 2019 All rights reserved. <a href="#">{{ site_name }}</a>.</span> | ||
| <script | ||
| charset="utf-8" | ||
| type="text/javascript" | ||
| src="//js.hsforms.net/forms/v2-legacy.js" | ||
| ></script> | ||
| <script | ||
| charset="utf-8" | ||
| type="text/javascript" | ||
| src="//js.hsforms.net/forms/v2.js" | ||
| ></script> | ||
| <script> | ||
| if (typeof hbspt !== "undefined") { | ||
| hbspt.forms.create({ | ||
| portalId: "{{ hubspot_portal_id }}", | ||
| formId: "{{ hubspot_footer_form_guid }}", | ||
| }); | ||
| } | ||
| </script> | ||
| </div> | ||
| </div> | ||
| <ul class="footer-sub-nav"> | ||
| <li><a href="/terms-of-service/">Terms of Service</a></li> | ||
| <li><a href="/privacy-policy/">Privacy Policy</a></li> | ||
| <li><a href="/honor-code/">Honor Code</a></li> | ||
| <li> | ||
| <a | ||
| target="_blank" | ||
| href="https://accessibility.mit.edu/" | ||
| rel="noopener noreferrer" | ||
| >Accessibility</a | ||
| > | ||
| </li> | ||
| </ul> | ||
| <span class="copyright" | ||
| >© 2019 All rights reserved. <a href="#">{{ site_name }}</a>.</span | ||
| > | ||
| </div> | ||
| </footer> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not fix everything we want to. Refer to the lighthouse report which still flags this as an issue:
The recommended way of fixing it:
https://web.dev/font-display/?utm_source=lighthouse&utm_medium=devtools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's done exactly that way and I don't see that error on my side.