Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIRTS-4695] Fix Deprecated Manx Socket Issues #2852

Closed
wants to merge 6 commits into from

Conversation

bleepbop
Copy link
Contributor

@bleepbop bleepbop commented Dec 1, 2023

Description

Fixes deprecated Python 3 error which discontinues send/receive functionality of TransportSockets. Manx repo changes must be merged first changes to the Manx plugin., and merging those changes should resolve the unit test issues in this repo. This PR is ready for review, but is marked as a draft to prevent accidental merging.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Tested manually, can confirm manx plugin works without error.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@bleepbop bleepbop marked this pull request as ready for review December 19, 2023 21:51
@bleepbop bleepbop marked this pull request as draft December 19, 2023 21:52
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Copy link

github-actions bot commented Mar 2, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants