Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIRTS-4793] Fix deprecated socket issues #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bleepbop
Copy link

@bleepbop bleepbop commented Dec 1, 2023

Description

Fixes deprecated Python 3 TransportSocket send/receive issues. Adds new Connection object that makes use of Read/Write streams instead of direct socket usage. Must be merge along with main Caldera repo changes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@bleepbop bleepbop marked this pull request as ready for review December 19, 2023 21:50
@bleepbop bleepbop requested a review from clenk December 19, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant