Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route incref via vtable to avoid alignment issues #516

Merged
merged 3 commits into from
May 25, 2024
Merged

Conversation

mitsuhiko
Copy link
Owner

This method was previously not sound when the alignment of the type was larger than the necessary alignment for the atomic counters.

@mitsuhiko
Copy link
Owner Author

The CI failure is a change in nightly (rust-lang/rust#125319) caused by a new type implementation (rust-lang/rust#99969). Upgrading the time dependency to avoid this issue.

@mitsuhiko mitsuhiko merged commit bffacbf into main May 25, 2024
30 checks passed
@mitsuhiko mitsuhiko deleted the align-dynobj-clone branch May 25, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant