Load new CA Certificate from file on certificate error #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Vault.ts
Outdated
| @@ -8,6 +8,7 @@ import { resolveURL } from "./util"; | |||
| import { TotpVaultClient } from "./engines/totp"; | |||
| import { KVVaultClient } from "./engines/kv"; | |||
| import { KV2VaultClient } from "./engines"; | |||
| import * as fs from "fs/promises"; | |||
There was a problem hiding this comment.
This import fails in the workflow. Looks like fs/promises is only available in Node ≥14 and weirdly, some versions of Node 10 (nodejs/node#35740 (comment)).
But maybe the workflow could do with a bump to a halfway-recent Node version, anyway. 🤷♂️
LGTM, otherwise. 👍
There was a problem hiding this comment.
Weird, I couldn't really figure out which api is recommended but switched to import { promises as fs } from 'fs'; to keep compatibility with node 12+
Lucaber
force-pushed
the
fix/ca-cert-reload
branch
from
a6684d5
to
6a0cad5
Compare
YannikBramkamp
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.