disallow focusing library feature buttons with Tab #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ronso0
force-pushed
the
no-focus-lib-feature-buttons
branch
from
620587d to
12a9aa5
Compare
|
Please see #2644 for testing all current lib navigation PRs combined. |
|
I'll merge now, this works good and we have too many PRs that still lack review. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library feature buttons in Recording, AutoDJ, Analysis, Hidden or Missing accept click focus only, not from
Tabkey or[Library]MoveFocus...(emulated Tab).Now it's easier to navigate the library with Tab as you don't have to tab through a row of feature buttons anymore to jump from the tree to the tracks tables and back.
There's no point in having those buttons focused as there's no way to trigger them, neither from keyboard or controllers. For AutoDJ and Recording there are keyboard shortcuts.
I added a focus border to WTextBrowser (library feature root view) so that it's always clear which part of the library is focused (links like Create New Playlist can still be selected).