Lib control & navigation optimizations -combined- #2644
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged #2597
#2598#2599#2628 #2632for personal use, and I can as well share it here.Facilitates building, in case someone likes to test those with a controllers.
(not for code review!)
With controller you can test
Library navigation
Navigation with
[Library],controls
should feel exactly like with arrow & Tab keys on a keyboard.[Library],MoveFocus...
should always move the focus like tab key does.No more getting stuck at the searchbox' Clear button, no more tabbing through AutoDJ button row etc.
If any non-library widget has focus (Beatsize spinbox or effect selector), issueing a scroll command
[Library],Move...
or[Library],Scroll...
should always re-focus the tracks table (or library feature root view).Check: when scrolling in any feature's track table with these controls, there should not pop up any additional "Tab key" events in the log stream.
[Playlist],SelectPlaylist
and[Playlist],SelectTrackKnob
should work as before.Clear search from controller
Enter a search term, focus tracks table or anything else, then use Tab or
[Library],MoveFocus...
to focus the Clear button. Use[Library],GoToItem
to clear the searchbox.