-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PaAlsa_EnableRealtimeScheduling fix #3160
Conversation
What's the precise reason for the crash? Are we passing a structure layout that has been determined at compile time to a dynamically loaded library that might use a different layout internally? |
Yes, that is one reason, that only happens during development. |
There's a merge conflict. Also, I can try to do a code review but I have no idea how to test this properly. |
@Holzhaus There is not much to test. If it does not crash it is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is not much to test. If it does not crash it is fine.
It doesn't crash. I can't really judge the code though.
Do you have questions? |
I still don't completely understand how this works and why it is safe. Do you have any references or links that we could add to the code? |
I have just realized the the pa_linux_alsa.h is now part of the distribution. Here is the reference link. I don't think there is any need to put it into the code, now we have the header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awaiting CI results.
Check the CI failures. All seem to be unrelated. LGTM |
This fixes a crash I have uncounted during my testes with different Portaudio version.
Without this patch, the PaAlsa_EnableRealtimeScheduling writes a random byte in the JACK case and if the PaAlsaStream structure changes.