Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lp1903462: PortAudio: Map host API index to type id #3277

Merged
merged 1 commit into from
Nov 10, 2020
Merged

lp1903462: PortAudio: Map host API index to type id #3277

merged 1 commit into from
Nov 10, 2020

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Nov 9, 2020 •
edited
Loading

https://bugs.launchpad.net/mixxx/+bug/1903462

Fixes wrong usage of host API index vs. type id that has been picked up by #3160.

@uklotzde uklotzde added this to the 2.2.5 milestone Nov 9, 2020
@uklotzde uklotzde requested a review from daschuer November 9, 2020 00:47
@uklotzde uklotzde added devices and removed engine labels Nov 9, 2020
@daschuer
Copy link
Member

It works:

daniel@540U4C:~$ ps -m -l 4593
F S   UID   PID  PPID  C PRI  NI ADDR SZ WCHAN  TTY        TIME CMD
0 -  1000  4593  2450 25   -   - - 1810219 -    pts/0      0:07 ./mixxx
0 S  1000     -     - 20  80   0 -     - poll_s -          0:05 -
1 S  1000     -     -  0  80   0 -     - poll_s -          0:00 -
1 S  1000     -     -  0  80   0 -     - poll_s -          0:00 -
1 S  1000     -     -  0  80   0 -     - poll_s -          0:00 -
1 S  1000     -     -  0  80   0 -     - poll_s -          0:00 -
1 S  1000     -     -  0  80   0 -     - poll_s -          0:00 -
1 S  1000     -     -  0  80   - -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   - -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   - -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   - -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - poll_s -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  1  80   0 -     - poll_s -          0:00 -
1 S  1000     -     -  0  80   0 -     - hrtime -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - poll_s -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -
1 S  1000     -     -  1  80   0 -     - poll_s -          0:00 -
1 S  1000     -     -  2 -23   - -     - poll_s -          0:00 -
1 S  1000     -     -  0  80   0 -     - futex_ -          0:00 -

@daschuer
Copy link
Member

Thank you for investigation and finding the root cause.
Because of the second issue my original patch was so obvious that I have failed to actually check the priority.

daschuer
daschuer approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am glad that we have a fix in such a short time.

@daschuer
Copy link
Member

All CI is failing :-/ ... but unrelated.

@daschuer daschuer merged commit 73ff6d5 into mixxxdj:2.2 Nov 10, 2020
@MarcPlace
Copy link

I will give it a try tonight when I'm back home. Thanks again for fixing this issue.
Marco

@MarcPlace
Copy link

LGTM here, too.

Before:

marco@legolas ~ $ ps -m -l 12755
F S   UID   PID  PPID  C PRI  NI ADDR SZ WCHAN  TTY        TIME CMD 
0 -  1000 12755  9651 24   -   - - 1127580 -    pts/1      0:32 mixxx
0 S  1000     -     - 15  80   0 -     - -      -          0:21 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   - -     - -      -          0:00 -
1 S  1000     -     -  0  80   - -     - -      -          0:00 -
1 S  1000     -     -  0  80   - -     - -      -          0:00 -
1 S  1000     -     -  0  80   - -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  2  80   0 -     - -      -          0:03 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 R  1000     -     -  4  80   0 -     - -      -          0:05 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -

After:

marco@legolas ~ $ ps -m -l 11575 
F S   UID   PID  PPID  C PRI  NI ADDR SZ WCHAN  TTY        TIME CMD
0 -  1000 11575  9651 30   -   - - 1131202 -    pts/1      2:38 mixxx
0 S  1000     -     - 15  80   0 -     - -      -          1:21 -
1 S  1000     -     -  0  80   0 -     - -      -          0:01 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   - -     - -      -          0:00 -
1 S  1000     -     -  0  80   - -     - -      -          0:00 -
1 S  1000     -     -  0  80   - -     - -      -          0:00 -
1 S  1000     -     -  0  80   - -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:01 -
1 S  1000     -     -  0  80   0 -     - -      -          0:01 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  7  80   0 -     - -      -          0:39 -
1 S  1000     -     -  2  80   0 -     - -      -          0:11 -
1 S  1000     -     -  0  80   0 -     - -      -          0:01 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  0  80   0 -     - -      -          0:00 -
1 S  1000     -     -  3 -23   - -     - -      -          0:19 -
1 S  1000     -     -  0 -23   - -     - -      -          0:00 -

@uklotzde uklotzde deleted the portaudio_hostapi branch November 13, 2020 10:22
@uklotzde uklotzde modified the milestones: 2.2.5, 2.3.0 May 11, 2021
This was referenced Aug 23, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
critical bug
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @daschuer @MarcPlace