Initialize m_enabled to true in PPHolonomicDriveController #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh. Don't know why I never noticed that. Can you move the initialization to the constructor in the cpp file here instead of the h file? I like to keep it all in the same place. |
|
Actually nvm, that's fine in the h file |
|
When this gets merged, I'm just going to replace the current 2024.1.5 release with the new build since I just pushed 2024.1.5 today. So, if you are already updated to that version you'll have to delete it from your gradle cache. |
|
Okay, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using PathPlanner for our robot, we are testing the code using a Gazebo simulation. The simulated robot didn't seem to turn at all, while the real robot did it without issue. We looked into it and found that the m_enabled check in PPHolonomicDriveController was failing, we believe it is because the variable is not assigned anything, leaving the compiler to decide its value. On Java the variable is set to true when its declared.