Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle digest mismatches caused by intentional changes to resources? #26

Closed
mjordan opened this issue Jan 2, 2019 · 5 comments
Closed

Comments

@mjordan
Copy link
Owner

mjordan commented Jan 2, 2019

Since Riprap compares digest from the current fixity check with the digest from the previous fixity check, an intentional modification to a resource will produce a failed comparison. This problem is not specific to Riprap but will happen in any service that takes this approach to fixity monitoring over time, e.g. hashdeep, Fixity, Tripwire.

Riprap can store "event detail" data but populating it with notifications that a resources has been intentionally changed (and that a change in the digest value is expected) is beyond the scope of Riprap itself.

@mjordan
Copy link
Owner Author

mjordan commented Jan 2, 2019

This might be a bit far flung but on mismatch, a postcheck plugin could query a remote API to see if the there was a corresponding updated date, etc. on the resource, and if so, add an event detail note. In terms of Islandora, we could check the media file's modified property.

@mjordan
Copy link
Owner Author

mjordan commented Jan 3, 2019

Maybe we can pass extra info like last modified date into the check_fixity command. Currently, we only pass the resource's URI, but we might be able to serialize additional info as JSON. That would avoid having to do another call back to Drupal as suggested in my previous comment.

mjordan added a commit that referenced this issue Jan 4, 2019
mjordan added a commit that referenced this issue Jan 4, 2019
mjordan added a commit that referenced this issue Jan 4, 2019
mjordan added a commit that referenced this issue Jan 7, 2019
mjordan added a commit that referenced this issue Jan 7, 2019
mjordan added a commit that referenced this issue Jan 7, 2019
@mjordan
Copy link
Owner Author

mjordan commented Jan 10, 2019

Work on this postponed until we explore #31. issue-31 branch created from this branch at 6acab00.

@mjordan
Copy link
Owner Author

mjordan commented Jan 14, 2019

This appears to be working as intended in the issue-31 branch. All fetchresourcelist plugins now return an array of objects with the properties 'resource_id' and 'last_modified_timestamp'. Will close this after some more testing and when issue-31 is merged into master.

@mjordan
Copy link
Owner Author

mjordan commented Jan 21, 2019

Resolved as part of #31.

@mjordan mjordan closed this as completed Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant