explorer small fix

[Hakimovich99]

use as_posix to return the absolute path. Avoids denied mounting issue when calling the explorer.

[RobbeSneyders]

Thanks @Hakimovich99! Not sure if this will work on windows though. We can ask @janvanlooyml6 or @GeorgesLorre to test.

[Hakimovich99]

Thanks @Hakimovich99! Not sure if this will work on windows though. We can ask @janvanlooyml6 or @GeorgesLorre to test.

Works on Windows as well:)

[GeorgesLorre]

cmd.extend(
      ["-v", f"/{shlex.quote(host_machine_path)}:/{shlex.quote(container_path)}"],
)

Do we still need the slashes here ? (line 63)

[Hakimovich99]

cmd.extend(
      ["-v", f"/{shlex.quote(host_machine_path)}:/{shlex.quote(container_path)}"],
)

Do we still need the slashes here ? (line 63)

Seems to work without them

cmd.extend(
>       ["-v", f"{shlex.quote(host_machine_path)}:{shlex.quote(container_path)}"],
> )

[RobbeSneyders]

Can you remove the slashes as part of this PR as well?

[Hakimovich99]

Can you remove the slashes as part of this PR as well?

Well can't figure out why but the checks are not successful after removing the slashes... Any idea @RobbeSneyders ?

[RobbeSneyders]

You'll need to remove the slashes in the failing test as well:
https://github.com/ml6team/fondant/blob/explorer_fix/tests/test_explorer.py#L59

[Hakimovich99]

You'll need to remove the slashes in the failing test as well: https://github.com/ml6team/fondant/blob/explorer_fix/tests/test_explorer.py#L59

Done, thanks Robbe!

[RobbeSneyders]

Thanks!