Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling a ListItem does not grey out secondaryText color #997

Closed
stickfigure opened this issue Nov 6, 2020 · 0 comments · Fixed by #1000
Closed

Disabling a ListItem does not grey out secondaryText color #997

stickfigure opened this issue Nov 6, 2020 · 0 comments · Fixed by #1000
Labels
bug
Milestone
v2.4.3

Comments

@stickfigure
Copy link
Contributor

Describe the bug A clear and concise description of what the bug is.

When a ListItem is disabled, the primary text greys out but the secondary text remains as-is (and ends up darker than primary, which looks odd).
@stickfigure stickfigure added the bug label Nov 6, 2020
mlaursen added a commit that referenced this issue Nov 14, 2020
@mlaursen
fix(list): fixed ListItem disabled colors to optionally include addons
a40b6b3 
The new `disabledOpacity` prop will allow for the full ListItem to gain
an opacity value while disabled instead of only setting the color
values. This allows the addons to also be dimmed.

fix #997
@mlaursen mlaursen mentioned this issue Nov 14, 2020
Merged
@mlaursen mlaursen added this to the v2.4.3 milestone Nov 14, 2020
@mlaursen mlaursen mentioned this issue Nov 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.4.3
Development

Successfully merging a pull request may close this issue.

Fix ListItem Disabled Behavior mlaursen/react-md
2 participants
@stickfigure @mlaursen