Fix ListItem Disabled Behavior #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better mimics the button behavior that it inherits, but can still be set to 0 or another tabIndex if needed. fix #997
The new `disabledOpacity` prop will allow for the full ListItem to gain an opacity value while disabled instead of only setting the color values. This allows the addons to also be dimmed. fix #997
Codecov Report
@@ Coverage Diff @@
## main #1000 +/- ##
=======================================
Coverage 88.89% 88.90%
=======================================
Files 248 248
Lines 6980 6983 +3
Branches 1808 1812 +4
=======================================
+ Hits 6205 6208 +3
Misses 698 698
Partials 77 77
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
ListItemfrom being focusable by default when disabled. This better mimics the button behavior that it inherits, but can still be set to 0 or another tabIndex if needed.ListItemsecondary textListItemthat allows thedisabledstate to be applied with opacity instead of colors. This allows for the addons to also gain a disabled state$rmd-list-item-disabled-opacity: 0.5! default;value for thedisabledOpacitypropCloses #997
Visual Examples
Light Theme
Default ListItem
Disabled ListItem
Disabled Opacity ListItem
Default ListItem with Addons
Disabled ListItem with Addons
Disabled Opacity ListItem with Addons
Dark Theme
Default ListItem
Disabled ListItem
Disabled Opacity ListItem
Default ListItem with Addons
Disabled ListItem with Addons
Disabled Opacity ListItem with Addons