Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CM/CMX] check control flags for CM/CMX access function and fail if flags/keys are not recognized #1315

Closed
gfursin opened this issue Oct 11, 2024 · 1 comment
Closed

[CM/CMX] check control flags for CM/CMX access function and fail if flags/keys are not recognized #1315

gfursin opened this issue Oct 11, 2024 · 1 comment
Assignees
@gfursin
Labels
cm-core cmx-core enhancement

Comments

@gfursin
Copy link
Contributor

gfursin commented Oct 11, 2024

CM/CMX access function should fail in case of unknown flags/keys...
@gfursin gfursin self-assigned this Oct 11, 2024
gfursin added a commit to flexaihq/ck that referenced this issue Oct 13, 2024
@gfursin
- improved CMX logging (-log and -logfile): mlcommons#1317
382ac4b 
- print control flags in help (cmx -h | cmx -help): mlcommons#1318
- fail if control flag is not recognized: mlcommons#1315
gfursin added a commit to flexaihq/ck that referenced this issue Oct 13, 2024
@gfursin
V3.2.0:
b5e87b7 
   - added `utils.test_input` to test if input has keys
     and report them as error
   - added `prefix_cmx` key to cmr.yaml to customize `cmx pull repo`
   - improved CMX logging (-log and -logfile):
     mlcommons#1317
   - print control flags in help (cmx -h | cmx -help):
     mlcommons#1318
   - fail if control flag is not recognized:
     mlcommons#1315
   - added -repro flag to record various info to cmx-repro directory
     mlcommons#1319
   - print call stack when error > 32 to be able to trace error cause:
     mlcommons#1320
     can be combined with -log=debug and -logfile
@gfursin gfursin mentioned this issue Oct 13, 2024
Merged
@gfursin
Copy link
Contributor Author

gfursin commented Oct 13, 2024

Added in #1321

@gfursin gfursin closed this as completed Oct 13, 2024
gfursin added a commit that referenced this issue Oct 13, 2024
@gfursin
V3.2.0: many important improvements (#1321)
72734a1 
I added many important features to CMX pending for a very long:
- added `utils.test_input` to test if input has keys and report them as
error
   - added `prefix_cmx` key to cmr.yaml to customize `cmx pull repo`
- improved CMX logging (-log and -logfile):
#1317
- print control flags in help (cmx -h | cmx -help):
#1318
- fail if control flag is not recognized:
#1315
- added -repro flag to record various info to cmx-repro directory:
#1319
- print call stack when error > 32 to be able to trace error cause:
#1320
     can be combined with -log=debug and -logfile
@gfursin gfursin mentioned this issue Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfursin gfursin

Labels
cm-core cmx-core enhancement
Projects
CM as next generation of CK
Status: Done
CMX as next generation of CM (version 3.x)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gfursin