-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3.2.0: many important improvements #1321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v3.1.0: simplified and changed process_input function API (mlcommons#1314)
- print control flags in help (cmx -h | cmx -help): mlcommons#1318 - fail if control flag is not recognized: mlcommons#1315
mlcommons#1320 can be combined with -log=debug and -logfile
- added `utils.test_input` to test if input has keys and report them as error - added `prefix_cmx` key to cmr.yaml to customize `cmx pull repo` - improved CMX logging (-log and -logfile): mlcommons#1317 - print control flags in help (cmx -h | cmx -help): mlcommons#1318 - fail if control flag is not recognized: mlcommons#1315 - added -repro flag to record various info to cmx-repro directory mlcommons#1319 - print call stack when error > 32 to be able to trace error cause: mlcommons#1320 can be combined with -log=debug and -logfile
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This was referenced Oct 13, 2024
ctuning-admin
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many important features that should not touch legacy CM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added many important features to CMX pending for a very long:
utils.test_input
to test if input has keys and report them as errorprefix_cmx
key to cmr.yaml to customizecmx pull repo
can be combined with -log=debug and -logfile