Add perf event support #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ce0c3f9.
caizixian
added a commit
that referenced
this pull request
May 28, 2021
This PR refactors work-packet level statistics collection. Work packet execution time measuring was hardcoded. It's now abstracted through a WorkCounter trait interface. This PR also makes #315 easier.
k-sareen
pushed a commit
to k-sareen/mmtk-core
that referenced
this pull request
Jun 10, 2021
This PR refactors work-packet level statistics collection. Work packet execution time measuring was hardcoded. It's now abstracted through a WorkCounter trait interface. This PR also makes mmtk#315 easier.
|
EDIT: Nvm, the issue is that Intel CPUs do not have as many performance counters as AMD CPUs. I should I realized the issue from the comment at the assertion |
qinsoon
reviewed
Jun 15, 2021
qinsoon
added
the
PR-testing
qinsoon
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports measuring perf event for work packets.
The added code is guarded behind a feature
perfdue to an upstream bug in bindgen.rust-lang/rust-bindgen#1538
rust-lang/rust#59154