Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support measuring process-wide perf events #357

Merged
merged 17 commits into from
Jul 11, 2021
Merged

Support measuring process-wide perf events #357

merged 17 commits into from
Jul 11, 2021

Conversation

caizixian
Copy link
Member

@caizixian caizixian commented Jun 29, 2021 •
edited
Loading

PR #315 added support for measuring perf events for work packets.
This PR support process-wide measurements of perf events, so we can know, say the total cycles, spent in mutators/GC.

@caizixian caizixian changed the title Support measuring perf events for mutator and GC Support measuring perf events process-wide Jun 29, 2021
@caizixian caizixian marked this pull request as ready for review June 29, 2021 12:08
@caizixian caizixian changed the title Support measuring perf events process-wide Support measuring process-wide perf events Jun 29, 2021
qinsoon
qinsoon approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you confirm that this implementation works? I did a quick implementation almost the same as this, but the read value I got for gc/mu is 0 - so I gave up on that.

src/memory_manager.rs Show resolved Hide resolved
src/util/options.rs Show resolved Hide resolved
src/util/statistics/stats.rs Outdated Show resolved Hide resolved
src/util/statistics/counter/mod.rs Outdated Show resolved Hide resolved
@caizixian
Copy link
Member Author

LGTM. Did you confirm that this implementation works? I did a quick implementation almost the same as this, but the read value I got for gc/mu is 0 - so I gave up on that.

Yes, I did test it.
image

@caizixian caizixian merged commit 62ccbc7 into master Jul 11, 2021
@caizixian caizixian deleted the perf-counter-phase branch July 11, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinsoon qinsoon qinsoon approved these changes

@wenyuzhao wenyuzhao Awaiting requested review from wenyuzhao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caizixian @qinsoon