Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] FIX: Use os.replace instead of os.rename when copying CTF files (needed for windows) #1035

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Aug 2, 2022

xref: https://mne.discourse.group/t/using-mne-bids-to-convert-ctf-data-to-bids-format/5336/17

PR Description

replace seems to be windows friendly.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to .zenodo.json
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1035 (815bdf4) into main (ace2a7d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1035   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          25       25           
  Lines        3787     3787           
=======================================
  Hits         3605     3605           
  Misses        182      182           
Impacted Files Coverage Δ
mne_bids/copyfiles.py 97.61% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hoechenberger
Copy link
Member

Nice, can you add a changelog entry please?

@sappelhoff sappelhoff changed the title fix: replace instead of rename for win support [MRG] FIX: Use os.replace instead of os.rename when copying CTF files (needed for windows) Aug 2, 2022
doc/whats_new.rst Outdated Show resolved Hide resolved
@hoechenberger hoechenberger enabled auto-merge (squash) August 2, 2022 17:06
@hoechenberger hoechenberger merged commit 491ac8d into mne-tools:main Aug 2, 2022
@hoechenberger
Copy link
Member

Thanks @sappelhoff!

@sappelhoff sappelhoff deleted the fix/ctf/rename branch August 2, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants