Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] FIX: Use os.replace instead of os.rename when copying CTF files (needed for windows) #1035

Merged
merged 3 commits into from
Aug 2, 2022
+4 −2
Merged

[MRG] FIX: Use os.replace instead of os.rename when copying CTF files (needed for windows) #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f83549b
fix: replace instead of rename for win support
sappelhoff Aug 2, 2022
2f41d5b
add changelog
sappelhoff Aug 2, 2022
815bdf4
Update doc/whats_new.rst
hoechenberger Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/whats_new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ Detailed list of changes

- :func:`~mne_bids.read_raw_bids` doesn't populate ``raw.info['subject_info']`` with invalid values anymore, preventing users from writing the data to disk again, by `Richard Höchenberger`_ (:gh:`1031`)

- Writing and copying CTF files now works on Windows when files already exist (``overwrite=True``), by `Stefan Appelhoff`_ (:gh:`1035`)

:doc:`Find out what was new in previous releases <whats_new_previous_releases>`

.. include:: authors.rst
4 changes: 2 additions & 2 deletions mne_bids/copyfiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ def copyfile_ctf(src, dest):
bids_folder_name = op.splitext(op.split(dest)[-1])[0]
for fname in fnames:
ext = op.splitext(fname)[-1]
os.rename(op.join(dest, fname),
op.join(dest, bids_folder_name + ext))
os.replace(op.join(dest, fname),
op.join(dest, bids_folder_name + ext))


def copyfile_kit(src, dest, subject_id, session_id,
Expand Down