Mnes 468 create an automatic testing strategy #91

fleanegan · 2024-09-16T13:18:17Z

Description

Please include a summary of the changes and link the related github issue.
Please include relevant motivation and context.

Fixes # (Issue)

Type of change

Please delete options that are not relevant.

Minor change (non-breaking change, e.g. documentation adaption)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that causes existing functionality to not work as expected)

Checklist:

I have performed a self-review of my code
My changes generate no new warnings
I have added tests that prove my fix or my feature works
New and existing tests pass locally with my changes
My changes contain no console logs

Small bug fix in the README

Version 1.1.0

…view (#64) # Description new <QrScanner /> component: Clicking on the QR scanner logo will open the camera. It will continuously scan for a qr code and execute the onScan callback if a valid one was found: - Dashboard: Will open the page with the specific ID - Compare: Will add the AAS to the compare list Fixes # (MNES-1175) ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) # Checklist: - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [x] New and existing tests pass locally with my changes - [x] My changes contain no console logs

# Description Added SQLite database and schema + seeding with prisma. ## Type of change Please delete options that are not relevant. - [ ] New feature (non-breaking change which adds functionality) # Checklist: - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [ ] New and existing tests pass locally with my changes - [ ] My changes contain no console logs

…nto feat(repositry-settings) # Conflicts: # yarn.lock

# Description Added form for editing the repository list ## Type of change Please delete options that are not relevant. - [ ] New feature (non-breaking change which adds functionality) # Checklist: - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [ ] New and existing tests pass locally with my changes - [ ] My changes contain no console logs --------- Co-authored-by: Milo Franke <milo.franke@xitaso.com>

#73) # Description Please include a summary of the changes and link the related github issue. Please include relevant motivation and context. Fixes # (Issue) ## Type of change Please delete options that are not relevant. - [ ] Minor change (non-breaking change, e.g. documentation adaption) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that causes existing functionality to not work as expected) # Checklist: - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [ ] New and existing tests pass locally with my changes - [x] My changes contain no console logs --------- Co-authored-by: melanie.gail <melanie.gail@xitaso.com> Co-authored-by: milo.franke <milo.franke@xitaso.com>

# Description Refactoring of the IdSettings to match the new layout. ## Type of change Please delete options that are not relevant. - [ ] New feature (non-breaking change which adds functionality) # Checklist: - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [ ] New and existing tests pass locally with my changes - [ ] My changes contain no console logs

Co-authored-by: melanie.gail <melanie.gail@xitaso.com>

…ocker image (#62) # Description The github runner was pulling all images and was overwriting the freshly build mnestix-browser image. Because each action is started with a blank slate, the pull command is not required. docker compose up will pull the missing images . Fixes # (MNES-1168) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) # Checklist: - [x] I have performed a self-review of my code - [x] My changes generate no new warnings - [x] New and existing tests pass locally with my changes - [x] My changes contain no console logs

#66) # Description Previously, the version number was not displayed when turning off the authentication due to a small logic error. ## Type of change Please delete options that are not relevant. - [ ] Minor change (non-breaking change, e.g. documentation adaption) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that causes existing functionality to not work as expected)

Co-authored-by: melanie.gail <melanie.gail@xitaso.com> Co-authored-by: Milo Franke <milo.franke@xitaso.com> Co-authored-by: Jonathan Sigrist <jonathan.sigrist@xitaso.com>

# Description Please include a summary of the changes and link the related github issue. Please include relevant motivation and context. Fixes # (Issue) ## Type of change Please delete options that are not relevant. - [x] Minor change (non-breaking change, e.g. documentation adaption) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that causes existing functionality to not work as expected) # Checklist: - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [ ] New and existing tests pass locally with my changes - [x] My changes contain no console logs

…del repository (#68) # Description The change enables users to configure a separate aas repository and submodel repository Fixes # (Issue) ## Type of change Please delete options that are not relevant. - [x] Minor change (non-breaking change, e.g. documentation adaption) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that causes existing functionality to not work as expected) # Checklist: - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [ ] New and existing tests pass locally with my changes - [x] My changes contain no console logs

…v2 (#76) # Description Please include a summary of the changes and link the related github issue. Please include relevant motivation and context. Fixes # (Issue) ## Type of change Please delete options that are not relevant. - [ ] Minor change (non-breaking change, e.g. documentation adaption) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that causes existing functionality to not work as expected) # Checklist: - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [x] New and existing tests pass locally with my changes - [x] My changes contain no console logs

…78) # Description Enable QR scanner in dashboard and compare view ## Type of change - [x] New feature (non-breaking change which adds functionality) # Checklist: - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix or my feature works - [x] New and existing tests pass locally with my changes - [x] My changes contain no console logs

# Description Please include a summary of the changes and link the related github issue. Please include relevant motivation and context. Fixes # (Issue) ## Type of change Please delete options that are not relevant. - [x] Minor change (non-breaking change, e.g. documentation adaption) # Checklist: - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix or my feature works - [x] New and existing tests pass locally with my changes - [x] My changes contain no console logs --------- Co-authored-by: NilsXitaso <nils.rothamel@xitaso.com>

…NES-468-create-an-automatic-testing-strategy

…earchServer.ts

When there is an AAS with the same AAS ID in multiple repos, after searching, we want to display a result list of all encountered AAS with the same ID, and then let the user select which AAS to display in the detail view. --------- Co-authored-by: NilsXitaso <nils.rothamel@xitaso.com> Co-authored-by: milo.franke <milo.franke@xitaso.com>

…pattern

# Description Allows to configure multiple submodel repositories ( only in setting - search not included in this PR) --------- Co-authored-by: Milo Franke <milo.franke@xitaso.com>

…omatic-testing-strategy

…NES-468-create-an-automatic-testing-strategy

…omatic-testing-strategy

src/app/[locale]/settings/_components/mnestix-connections/PrismaConnector.ts

cypress.config.ts

cypress/e2e/compareViewTest.spec.js

cypress/e2e/listAasPageComparisonTest.spec.js

cypress/support/commands.ts

src/app/[locale]/settings/_components/mnestix-connections/MnestixConnectionServerActions.ts

src/lib/services/searchUtilActions/AasSearcher.ts

src/lib/services/searchUtilActions/searchServer.ts

Co-authored-by: Milo Franke <milo.franke@xitaso.com>

src/lib/searchUtilActions/searchClient.ts

src/lib/services/searchUtilActions/search.spec.ts

GailMelanie · 2024-09-18T09:39:24Z

src/lib/services/MultipleRepositorySearch/PrismaConnector.ts

@@ -0,0 +1,58 @@
+import { prisma } from 'lib/database/prisma';


I would put the PrismaConnector* files in the lib/database folder since the connection to the db is used in multiple places (and will be used for more than Repositroy Urls in the future). But it's fine for me if we tackle this in the API Refactoring Mob Programming.

src/lib/services/searchUtilActions/AasSearcher.ts

JonathanXITASO · 2024-09-17T13:45:53Z

cypress/e2e/listAasPageComparisonTest.spec.js

+        cy.screenshot('list-selected.png');
        cy.getByTestId('compare-button').click();
-        cy.wait(100);
        cy.url().should('contain', '/compare');
+        cy.wait(60000);
+        cy.getByTestId('compare-aas-0').should('be.visible');
+        cy.getByTestId('compare-aas-1').should('be.visible');


remove debug calls

JonathanXITASO · 2024-09-17T13:46:28Z

cypress/e2e/listAasPageComparisonTest.spec.js

        cy.visit('/list');
+        cy.setResolution(resolutions[0]);


why switch? for me the resolution is part of the setup and shoud be set first

JonathanXITASO · 2024-09-17T13:47:19Z

cypress/support/commands.ts

 });

 Cypress.Commands.add('getByTestId', (dataTestId) => {
-    cy.get('[data-testid=' + dataTestId + ']');
+    cy.get('[data-testid=' + dataTestId + ']', { timeout: 20000 });


use cy.getByTestId()
is explicit timeout necessary here?

cypress.config.ts

JonathanXITASO · 2024-09-18T08:21:26Z

src/lib/services/multipleDataSourceActions/multipleDataSourceActions.ts

+    return searcher.getSubmodelFromAllRepos(searchInput);
+}
+
+export async function performgetAasThumbnailFromAllRepos(searchInput: string): Promise<Blob> {


typo

Suggested change

export async function performgetAasThumbnailFromAllRepos(searchInput: string): Promise<Blob> {

export async function performGetAasThumbnailFromAllRepos(searchInput: string): Promise<Blob> {

JonathanXITASO · 2024-09-18T11:04:57Z

cypress/e2e/listAasPageComparisonTest.spec.js

        cy.url().should('contain', '/compare');
+        cy.wait(60000);


remove debug wait

NilsXitaso and others added 30 commits June 27, 2024 15:20

Update README.md (#14) (#15)

73966fd

Small bug fix in the README

Merge pull request #61 from mnestix/dev

a8a3f91

Version 1.1.0

Merge remote-tracking branch 'refs/remotes/origin/feat(qr-scanner)' i…

f652e81

…nto feat(repositry-settings) # Conflicts: # yarn.lock

docs(Submodel Registry): Add submodel registry description (#63)

dbe25be

Co-authored-by: melanie.gail <melanie.gail@xitaso.com>

fix(Asset redirect): fix asset redirect (#65)

dfc7922

feat(keycloak): setup keycloak azure instance (#59)

93cd96c

Co-authored-by: melanie.gail <melanie.gail@xitaso.com> Co-authored-by: Milo Franke <milo.franke@xitaso.com> Co-authored-by: Jonathan Sigrist <jonathan.sigrist@xitaso.com>

test strategy: aas search moved to server and made testable

be6af21

test strategy: added jest

59975c6

Merge remote-tracking branch 'origin/feat(repositry-settings)' into M…

18d9387

…NES-468-create-an-automatic-testing-strategy

test strategy: extracted interfaces for all the dependencies of the s…

3b43420

…earchServer.ts

test strategy: first test

1207edb

test strategy: happy paths for searchServer

827f34e

test strategy: transform dependencies of searchServer into nullables-…

14aa17b

…pattern

Mnes 1209 create UI for submodel repositories (#81)

3185a4e

# Description Allows to configure multiple submodel repositories ( only in setting - search not included in this PR) --------- Co-authored-by: Milo Franke <milo.franke@xitaso.com>

test strategy: searchServer advances on testing the edge cases

4d48958

Merge remote-tracking branch 'origin/dev' into MNES-468-create-an-aut…

a1e0228

…omatic-testing-strategy

Merge remote-tracking branch 'origin/feat(repositry-settings)' into M…

42c7bd7

…NES-468-create-an-automatic-testing-strategy

Frederik Schlüter added 2 commits September 16, 2024 16:48

Merge remote-tracking branch 'origin/dev' into MNES-468-create-an-aut…

5869b12

…omatic-testing-strategy

updated compose.yml

847b651

fleanegan marked this pull request as ready for review September 16, 2024 15:17

fleanegan requested review from Xmilofranke, JonathanXITASO, andersfranzanders, GailMelanie, NilsXitaso, XAndreJentzsch and FranzXitaso September 16, 2024 15:17

GailMelanie reviewed Sep 17, 2024

View reviewed changes

src/app/[locale]/settings/_components/mnestix-connections/PrismaConnector.ts Outdated Show resolved Hide resolved

Xmilofranke reviewed Sep 17, 2024

View reviewed changes

fleanegan and others added 6 commits September 18, 2024 08:46

Update cypress/e2e/compareViewTest.spec.js

b4820e5

Co-authored-by: Milo Franke <milo.franke@xitaso.com>

Update src/lib/services/searchUtilActions/AasSearcher.ts

2000320

Co-authored-by: Milo Franke <milo.franke@xitaso.com>

Update src/lib/services/searchUtilActions/AasSearcher.ts

d312122

Co-authored-by: Milo Franke <milo.franke@xitaso.com>

Update src/lib/services/searchUtilActions/AasSearcher.ts

d79d4b4

Co-authored-by: Milo Franke <milo.franke@xitaso.com>

test strategy: apply to review comments

d16be54

test strategy: restore time outs

df7541f

GailMelanie reviewed Sep 18, 2024

View reviewed changes

src/lib/searchUtilActions/searchClient.ts Show resolved Hide resolved

GailMelanie reviewed Sep 18, 2024

View reviewed changes

src/lib/services/searchUtilActions/search.spec.ts Outdated Show resolved Hide resolved

Frederik Schlüter added 4 commits September 18, 2024 10:23

test strategy: replied to remaining comments of review

dd7fbf1

test strategy: fixed build

9fcd947

test strategy: refactor

da26de6

test strategy: responded to hidden comments

a1b2aab

GailMelanie reviewed Sep 18, 2024

View reviewed changes

FranzXitaso approved these changes Sep 18, 2024

View reviewed changes

src/lib/services/searchUtilActions/AasSearcher.ts Outdated Show resolved Hide resolved

Xmilofranke approved these changes Sep 18, 2024

View reviewed changes

fleanegan merged commit fd1e550 into dev Sep 18, 2024
2 checks passed

fleanegan deleted the MNES-468-create-an-automatic-testing-strategy branch September 18, 2024 10:05

JonathanXITASO reviewed Sep 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mnes 468 create an automatic testing strategy #91

Mnes 468 create an automatic testing strategy #91

fleanegan commented Sep 16, 2024 •

edited

Loading

GailMelanie Sep 18, 2024

JonathanXITASO Sep 17, 2024

JonathanXITASO Sep 17, 2024

JonathanXITASO Sep 17, 2024

JonathanXITASO Sep 18, 2024

JonathanXITASO Sep 18, 2024

		@@ -0,0 +1,58 @@
		import { prisma } from 'lib/database/prisma';

	export async function performgetAasThumbnailFromAllRepos(searchInput: string): Promise<Blob> {
	export async function performGetAasThumbnailFromAllRepos(searchInput: string): Promise<Blob> {

Mnes 468 create an automatic testing strategy #91

Mnes 468 create an automatic testing strategy #91

Conversation

fleanegan commented Sep 16, 2024 • edited Loading

Description

Type of change

Checklist:

GailMelanie Sep 18, 2024

Choose a reason for hiding this comment

JonathanXITASO Sep 17, 2024

Choose a reason for hiding this comment

JonathanXITASO Sep 17, 2024

Choose a reason for hiding this comment

JonathanXITASO Sep 17, 2024

Choose a reason for hiding this comment

JonathanXITASO Sep 18, 2024

Choose a reason for hiding this comment

JonathanXITASO Sep 18, 2024

Choose a reason for hiding this comment

fleanegan commented Sep 16, 2024 •

edited

Loading