Add more database config options and other cleanup #1
Conversation
| matrix_mau_environment_variables_extension: '' | ||
| matrix_bot_database_uri: 'sqlite:///data/maubot.db' | ||
| matrix_bot_maubot_port: 29316 | ||
| matrix_bot_maubot_secret: 'generate' |
There was a problem hiding this comment.
I am not sure this is a good default, but we should make it have a default.
There was a problem hiding this comment.
I think the default for port and database are fine. I don't see why you added matrix_bot_maubot_secret as this should be set by a user and it would be unsafe to have a default value. We currently enforce the user to set it manually which is fine I think
| matrix_mau_environment_variables_extension: '' | ||
| matrix_bot_database_uri: 'sqlite:///data/maubot.db' | ||
| matrix_bot_maubot_port: 29316 | ||
| matrix_bot_maubot_secret: 'generate' |
There was a problem hiding this comment.
I think the default for port and database are fine. I don't see why you added matrix_bot_maubot_secret as this should be set by a user and it would be unsafe to have a default value. We currently enforce the user to set it manually which is fine I think
|
For some reason I can't leave this response in line. It would be unsafe for everyone to have the same default value of the secret but why cant we generate a random one automatically? With this setting maubot generates it's own, but I do wonder if that means it gets regenerated each time. |
|
Regarding the |
add default for TG filter_mode
Fix Broken ma1sd Playbook Documentation Link
No description provided.