[17.12] [manager/dispatcher] Synchronize Dispatcher.Stop() with incoming rpcs. #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @anshulpundir PTAL: let me know if it's ok to include #2486 as well |
|
Its OK to include #2486, but you must also include #2492 @thaJeztah |
thaJeztah
force-pushed
the
17.12-backport-agent2
branch
from
968e75e
to
d4c64ed
Compare
Codecov Report
@@ Coverage Diff @@
## bump_v17.12 #2514 +/- ##
===============================================
- Coverage 66.92% 61.64% -5.28%
===============================================
Files 76 129 +53
Lines 11158 21263 +10105
===============================================
+ Hits 7467 13108 +5641
- Misses 2929 6751 +3822
- Partials 762 1404 +642 |
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com> (cherry picked from commit 6fa4dda) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com> (cherry picked from commit 7d507f6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com> (cherry picked from commit 0b2778a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
17.12-backport-agent2
branch
from
d4c64ed
to
faf6913
Compare
|
Added #2492 👍 |
|
Looks like additional changes may be needed: #2495 (comment) |
|
Update on the additional changes needed; moby/moby#36274 (review)
@anshulpundir @nishanttotla should this be ok to merge? |
|
Do we still need #2492 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2495 for 17.12
Also included #2486 to get a clean cherry-pick