Revert "[manager/dispatcher] Synchronize Dispatcher.Stop() with incoming rpcs." #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing rpcs." This reverts commit 0b2778a. Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
This was referenced Feb 20, 2018
|
LGTM. |
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2518 +/- ##
==========================================
+ Coverage 61.38% 61.42% +0.04%
==========================================
Files 133 133
Lines 21720 21710 -10
==========================================
+ Hits 13332 13335 +3
+ Misses 6953 6928 -25
- Partials 1435 1447 +12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0b2778a.
Need to revert since waitgroup Add() and Wait() itself need intricate synchronization and are not atomic. Will implement another way, likely a RWLock as @fcrisciani originally suggested.