Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace non-standard colors in reporter #1200 #1212

Closed
wants to merge 1 commit into from
Closed

Replace non-standard colors in reporter #1200 #1212

wants to merge 1 commit into from

Conversation

octref
Copy link

@octref octref commented May 13, 2014

Color 90-99 are not standard and their implementations vary among
terminals.
See http://en.wikipedia.org/wiki/ANSI_escape_code#CSI_codes
This has caused many Solarized theme users unable to see some output.

Color 90-99 are not standard and their implementations vary among
terminals.
See http://en.wikipedia.org/wiki/ANSI_escape_code#CSI_codes
This has caused many Solarized theme users unable to see some output.
@tj
Copy link
Contributor

tj commented May 16, 2014

still looks ugly to me :( I like my gray, standard or not

@octref
Copy link
Author

octref commented May 17, 2014

@visionmedia
If you don't like the gray color of your terminal, you can change it in the palette of your terminal(usually under "profile setting", and gray is the first color).
I know you are picky about colors, but so do others. Currently Mocha doesn't use the gray color other people have chosen in their terminal palette, and it doesn't offer a custom config so users can change the color codes.
This makes it impossible for others to explicitly control the gray color in their mocha output, because most terminal wouldn't have a config on the non-standard 90 color. On the contrast, color 30 is well-supported and can be easily configured in most terminals.

@tj
Copy link
Contributor

tj commented May 17, 2014

which would be gray if it's not the "bright black"? black is black, I'd like to keep black black personally but there's definitely room for a gray, that's why I ab(use) bright black so much

@octref
Copy link
Author

octref commented May 17, 2014

OK. I'll just write a custom reporter that doesn't base on base.js, and add it to the wiki for Solarized users.
You can close this issue and #1200

@jbnicolai
Copy link

@octref good solution!

@jbnicolai jbnicolai closed this Jul 12, 2014
@wilzbach
Copy link

Sorry for posting on this closed issue.
Hmm I don't have like to modify/patch mocha after every installation.

If it isn't possible to avoid the non-standard colors, could we do this change in the base.js as all reporters inherit the colors from it - and they still display the invisible grey. Would you accept a pull request for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants