-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix diff colors #1648
Fix diff colors #1648
Conversation
This might be my own fault, but would be it possible to keep the background colors untouched? As in, have Because for me, the first command's output is with values |
Actually, if you want to explicity set the background, then it should be 49 I think, not 40. (i.e. |
I'm fine with trying out additional variations if someone from @mochajs can weigh in first. For now, it seems like no one is watching the PRs here. cc @a8m @boneskull @danielstjules @dasilvacontin @jbnicolai @pkozlowski-opensource @travisjeffery |
Okay but 49 I think is the "default background color", so I think it should be that, if it indeed doesn't look ugly that is. (And 40 is "black".) |
I think the contrast will vary quite a bit depending on your terminal color profile. However, I do prefer the changes applied by this PR as it bring it closer to standard diff tools (svn diff, git diff) |
It will obviously, but 40 being "black" (which is probably a dark color for most themes) doesn't play nice with light-background themes, although it does with dark-background themes. But 49 I think should play nice with both? Have you checked if 49 looks different than 40 for your own case @danielstjules? |
Source for that: https://web.archive.org/web/20150319145101/http://misc.flogisoft.com/bash/tip_colors_and_formatting#background Although I'm not sure how credible that page is (but it ranks highly in google search results if that counts at all). |
I don't care much about explicitly setting the background color. It looks nicer for me that way but that's just OS X Terminal.app being weird, and I don't want to break things for people with light terminal themes. Updated the PR accordingly - @danielstjules I think this is good to go now. Also, could you take a look at #1647? It's another PR intended to make mocha's diff output consistent with standard tools. |
@nylen No worries. 👍 |
@vyp @danielstjules is this library still maintained?? |
I'm happy with this. +1 from me. Just wanna hear from one more contributor. @mochajs/mocha |
I'll take a gander at this later. |
@nylen thanks! |
This does not Fixes #802 for me. Because
I suggest to replace them to |
+1 for this issue -- I'm using the popular solarized scheme with rxvt-unicode, via solarized/xresources. My results are the same as @legomind's: unusable. |
Same here. I'm interested in seeing this fixed, but I don't have much time lately... |
So, 1) I just realized this isn't an issue, but a pull-request. 2) I updated to use the latest version and the error does not exist. @dasilvacontin, @legomind |
This fixes diffs being unnecessarily hard to read:
Before
![screen shot 2015-04-08 at 2 19 29 pm](https://cloud.githubusercontent.com/assets/227022/7053484/21374a02-ddfb-11e4-9074-4ef54629e1a3.png)
After
![screen shot 2015-04-08 at 2 22 03 pm](https://cloud.githubusercontent.com/assets/227022/7053485/26f375ce-ddfb-11e4-8cb8-93f786f16cb1.png)
Others are experiencing the same issue with standard terminal color schemes too: #1200 (comment)