Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused initial_direction from C# #2022

Merged
merged 8 commits into from
Dec 8, 2018
Merged

Remove unused initial_direction from C# #2022

merged 8 commits into from
Dec 8, 2018

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Dec 8, 2018 •
edited by eggrobin
Loading

Fix #2021.

Also remove Plugin::prediction_parameters_, and propagate the split of AdaptiveStepParameters and GeneralizedAdaptiveStepParameters to the flight plan, unifying them into a new FlightPlanAdaptiveStepParameters in the interface.

eggrobin
eggrobin approved these changes Dec 8, 2018
View reviewed changes
serialization/ksp_plugin.proto Outdated Show resolved Hide resolved
ksp_plugin/interface_body.hpp Show resolved Hide resolved
ksp_plugin/plugin.cpp Show resolved Hide resolved
@eggrobin eggrobin added the LGTM label Dec 8, 2018
@pleroy pleroy merged commit d682ca4 into mockingbirdnest:master Dec 8, 2018
@pleroy pleroy mentioned this pull request Dec 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eggrobin eggrobin eggrobin approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pleroy @eggrobin