Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused initial_direction from C# #2022

Merged
merged 8 commits into from
Dec 8, 2018
Merged

Remove unused initial_direction from C# #2022

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e1e5afe
Remove unused initial_direction from C#.
pleroy Dec 8, 2018
768890f
Propagate flight plan adaptive step parameters all the way to the C# …
pleroy Dec 8, 2018
81449f9
Compatibility value.
pleroy Dec 8, 2018
55f7b0c
Remove the prediction parameters
pleroy Dec 8, 2018
acadab5
Fix the tests.
pleroy Dec 8, 2018
5fdbfe8
Fix 2 failures.
pleroy Dec 8, 2018
2cd7821
All the tests pass.
pleroy Dec 8, 2018
643a3bf
After egg's review.
pleroy Dec 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ksp_plugin/interface_body.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,7 @@ inline bool operator==(NavigationManoeuvre const& left,
NaNIndependentEq(left.time_of_half_delta_v,
right.time_of_half_delta_v) &&
NaNIndependentEq(left.time_to_half_delta_v,
right.time_to_half_delta_v) &&
left.inertial_direction == right.inertial_direction;
right.time_to_half_delta_v);
}

inline bool operator==(NavigationManoeuvreFrenetTrihedron const& left,
Expand Down
6 changes: 0 additions & 6 deletions ksp_plugin/interface_flight_plan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,6 @@ NavigationManoeuvre ToInterfaceNavigationManoeuvre(
result.final_time = ToGameTime(plugin, manœuvre.final_time());
result.time_of_half_delta_v = ToGameTime(plugin, manœuvre.time_of_half_Δv());
result.time_to_half_delta_v = manœuvre.time_to_half_Δv() / Second;
Vector<double, Barycentric> const barycentric_inertial_direction =
manœuvre.InertialDirection();
Vector<double, World> const world_inertial_direction =
plugin.renderer().BarycentricToWorld(plugin.PlanetariumRotation())(
barycentric_inertial_direction);
result.inertial_direction = ToXYZ(world_inertial_direction);
return result;
}

Expand Down
3 changes: 0 additions & 3 deletions ksp_plugin_test/interface_flight_plan_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,6 @@ TEST_F(InterfaceFlightPlanTest, FlightPlan) {
EXPECT_EQ(20, navigation_manoeuvre.initial_mass_in_tonnes);
EXPECT_THAT(navigation_manoeuvre.burn.specific_impulse_in_seconds_g0,
AlmostEquals(30, 1));
EXPECT_EQ(40, navigation_manoeuvre.inertial_direction.x);
EXPECT_EQ(50, navigation_manoeuvre.inertial_direction.y);
EXPECT_EQ(60, navigation_manoeuvre.inertial_direction.z);

EXPECT_CALL(flight_plan, GetManœuvre(3))
.WillOnce(ReturnRef(navigation_manœuvre));
Expand Down
1 change: 0 additions & 1 deletion serialization/journal.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ message NavigationManoeuvre {
required double final_time = 6;
required double time_of_half_delta_v = 7;
required double time_to_half_delta_v = 8;
required XYZ inertial_direction = 9;
}

// Frenet trihedron at the beginning of the man�uvre.
Expand Down