Orient the camera in CelestialSphere, not World #3249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3235.
The reference rotation is used here:
Principia/ksp_plugin_adapter/planetarium_camera_adjuster.cs
Lines 64 to 76 in 0aa17d4
The rotation of the pivot is with respect to
World
. However, the game compensates for the planetarium rotation, and we only adjust the orientation maintained by the game, we do not maintain an authoritative camera orientation, so that we should not compensate for the planetarium rotation ourselves.