Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dashscope multimodal #92

Merged
merged 19 commits into from
Apr 9, 2024
Merged

add dashscope multimodal #92

merged 19 commits into from
Apr 9, 2024

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented Mar 20, 2024 •
edited by DavdGao
Loading

Description

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

DavdGao
DavdGao reviewed Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update model.md in tutorial, and see inline comments.

src/agentscope/models/dashscope_model.py Show resolved Hide resolved
tests/dashscope_test.py Show resolved Hide resolved
DavdGao
DavdGao reviewed Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix the typos, and this PR may be merged after #95

README.md Outdated Show resolved Hide resolved
README_ZH.md Outdated Show resolved Hide resolved
@DavdGao
Copy link
Collaborator

DavdGao commented Mar 26, 2024

Please solve conflicts accordingly, and add a format function for this multimodal wrapper. (Maybe like advanced_format function in DashScopeChatWrapper?)

DavdGao
DavdGao reviewed Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please solve conflicts and add a format function for the new model wrapper.

@DavdGao DavdGao requested a review from ZiTao-Li March 26, 2024 06:48
pan-x-c
pan-x-c reviewed Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments

README.md Outdated Show resolved Hide resolved
README_ZH.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/agentscope/models/dashscope_model.py Outdated Show resolved Hide resolved
src/agentscope/models/dashscope_model.py Show resolved Hide resolved
@DavdGao
Copy link
Collaborator

DavdGao commented Apr 4, 2024

@qbc2016 I updated the tutorial accordingly and unified the format function for multimodal wrapper. Please check if it's appropriate.

qbc2016
qbc2016 commented Apr 8, 2024
View reviewed changes
Copy link
Collaborator Author

@qbc2016 qbc2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments. Others LGTM.

DavdGao
DavdGao approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavdGao DavdGao merged commit 347bdfa into modelscope:main Apr 9, 2024
5 checks passed
@qbc2016 qbc2016 deleted the dev_dash_multi branch August 15, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan-x-c pan-x-c pan-x-c left review comments

@DavdGao DavdGao DavdGao approved these changes

@ZiTao-Li ZiTao-Li Awaiting requested review from ZiTao-Li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qbc2016 @DavdGao @pan-x-c