-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in PromptEngine and provide prompt construction strategy for most chat and generation APIs #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please refer to the inline comments
…t api; change the role in format function of dashscope chat api into "system"
…ent performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See wording problem in comment. Others parts LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Motivation
What's in this PR
role
field inMsg
classformat
functionformat
function)TBD:
prompt engine
module. Especially if we want to add prompt shrinking strategies in the future.role
field current useassistant
as default value and give a warning to remind users to fill this argument.preprocess
function ofDashScopeChatWrapper
is retained and can work withformat
function together.Checklist
Please check the following items before code is ready to be reviewed.