Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve storybook builder static build tests #2695

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

bashmish
Copy link
Member

@bashmish bashmish commented Apr 15, 2024

What I did

  1. updated deps (because e.g. tocbot issue was only visible with the latest version)
  2. write the storybook config which I use in the tests in such a way that warnings cause an error, but add some exceptions
  3. add tocbot as an exception for now while I'm trying to fix it in a better way (see ESM version tscanlin/tocbot#337) - this is not critical for us at the moment, but will be critical later when more people start to use autodocs and MDX and enable toc in the their storybooks

Copy link

changeset-bot bot commented Apr 15, 2024

⚠️ No Changeset found

Latest commit: 95d1dc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bashmish bashmish force-pushed the test/improve-storybook-builder-static-build-tests branch from 12d01e8 to 217c74e Compare April 15, 2024 12:43
@bashmish bashmish merged commit 482210f into master Apr 15, 2024
6 of 7 checks passed
@bashmish bashmish deleted the test/improve-storybook-builder-static-build-tests branch April 15, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant