-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][@storybook/theming][7.6.7]: Property '...' of type '...' is not assignable to 'string' index type 'CSSInterpolation' #25480
Comments
Thanks for reporting! I am able to reproduce by opening How does this affect your project though? I created a fresh project and set |
I'm not quite sure why it affects my project tbh, but it does 😅 |
Maybe because I am importing from |
I had the same issue: I got this error when building the component library, which was weird because storybook should not be part of that build process, but both projects are in the same repository. I then added those storybook files (folders like .storybook and our custom addon/theming code) to the tsconfig.json "exclude" part, which solved the problem. Run and build storybook still works fine, i guess the cli of storybook uses an internal config. |
I have completely oposite problem as mayerraphael, I can build my library that is not part of storybook build. But my storybook build is completely broken. I can stay on "@storybook/theming": "7.6.6" or skipLibCheck: true until fixed. |
Having this issue too after upgrade to 7.6.8. I am using Angular 16 There are a lot of type errors. See below. Probably this is related to
|
I'm having the same issue. setting skipLibCheck to true is not really an option, as it not only disables checks for node_modules, but also for local |
Here's our resolution that avoided managing specific library versions and avoided
|
I think this can be closed now. At least I don't get the errors anymore. |
Hi there! Thank you for opening this issue, but it has been marked as |
I'll have to revert that comment. With 7.6.15 and 7.6.16 it worked, but with 7.6.17 it fails again I'm suspecting, that you are generating the file My best bet is: due to the not-pinned versions, the persons releasing the packages might have a different source for these and therefore some releases work fine, while others are broken. Maybe the persons releasing these two versions could come together and see what differences there are? |
@SantoJambit can you tell us your framework and its version and node version? btw I also have this issue on node 18.18.0 and angular 17 |
I'm using react.
|
Confirmed : I saw it in my repository "@storybook/theming": "7.6.16" |
* chore: npm update * chore: npm outdated * chore: npm outdated * style: control flow * style: finish migration * fix: cherry pick storybook theming version storybookjs/storybook#25480
Describe the bug
When running typescript on a project that uses
@storybook/theming
, I'm getting a bunch of these typing errors:To Reproduce
simply open the
node_modules/@storybook/theming/dist/create-8dd9d29b.d.ts
file in vscode.System
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: