Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_excel drops blank rows #3884

Closed
ElLorans opened this issue Dec 26, 2021 · 1 comment · Fixed by #4161
Closed

read_excel drops blank rows #3884

ElLorans opened this issue Dec 26, 2021 · 1 comment · Fixed by #4161
Assignees
Labels
bug 🦗 Something isn't working

Comments

@ElLorans
Copy link

ElLorans commented Dec 26, 2021

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
  • Modin version (modin.__version__): 0.12.1
  • Python version: 3.10.1
  • Code we can use to reproduce:
import pandas as pd
import modin.pandas as md

pd_df = pd.read_excel("testing.xlsx)
md_df = md.read_excel("testing.xlsx")
print(pd_df.shape[0]-md_df.shape[0])

Describe the problem

When reading an excel file, modin drops blank rows, while pandas does not. I don't know how to prevent modin from skipping blank rows.

Source code / logs

File to reproduce the issue:
testing.xlsx

@naren-ponder
Copy link
Collaborator

@ElLorans Thanks for filing the Github issue, I was able to reproduce and will be fixing it as part of this release

@naren-ponder naren-ponder self-assigned this Jan 12, 2022
@naren-ponder naren-ponder added the bug 🦗 Something isn't working label Jan 12, 2022
naren-ponder added a commit to naren-ponder/modin that referenced this issue Feb 23, 2022
Signed-off-by: Naren Krishna <naren@ponder.io>
devin-petersohn pushed a commit that referenced this issue Feb 23, 2022
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Naren Krishna <naren@ponder.io>
vnlitvinov pushed a commit that referenced this issue Mar 17, 2022
Co-authored-by: Yaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Naren Krishna <naren@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🦗 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants