FIX-#3884: Fix read_excel() dropping empty rows #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naren-ponder
force-pushed
the
blank_rows
branch
from
ac0a547
to
f4ff778
Compare
Codecov Report
@@ Coverage Diff @@
## master #4161 +/- ##
==========================================
+ Coverage 86.71% 89.60% +2.89%
==========================================
Files 201 201
Lines 16798 16800 +2
==========================================
+ Hits 14566 15054 +488
+ Misses 2232 1746 -486
Continue to review full report at Codecov.
|
|
|
|
naren-ponder
force-pushed
the
blank_rows
branch
from
18098bc
to
4b9a4a5
Compare
mvashishtha
reviewed
Feb 7, 2022
|
Could you please add issue #3884 in the PR description? |
mvashishtha
previously approved these changes
Feb 8, 2022
naren-ponder
force-pushed
the
blank_rows
branch
from
cce0815
to
b32fe9d
Compare
There was a problem hiding this comment.
Thanks @naren-ponder! Looking at this, there may be cases where the partitions are parsing both values and border-only cells. Can we create a test case that is 50 rows or so with every other row being empty with a border? This implementation might fail that test from my understanding of the code.
Added a test case for this to |
naren-ponder
force-pushed
the
blank_rows
branch
from
991fd85
to
da1f549
Compare
dchigarev
reviewed
Feb 18, 2022
dchigarev
reviewed
Feb 18, 2022
mvashishtha
reviewed
Feb 23, 2022
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
…ctory (modin-project#4214) Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Naren Krishna <naren@ponder.io>
naren-ponder
force-pushed
the
blank_rows
branch
from
617dddc
to
2495d4a
Compare
Signed-off-by: Naren Krishna <naren@ponder.io>
jeffreykennethli
approved these changes
Feb 23, 2022
devin-petersohn
approved these changes
Feb 23, 2022
vnlitvinov
pushed a commit
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naren Krishna naren@ponder.io
What do these changes do?
In Pandas 1.3.0, read_excel behavior changes from dropping empty rows or rows with a border in .xlsx files to including them with "NaN" values. This Modin change ensures compatibility with Pandas. Resolves #3884.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date