Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter to warn for python implicit concatenation #3900

Closed
jeffreykennethli opened this issue Jan 7, 2022 · 0 comments · Fixed by #3901
Closed

Add linter to warn for python implicit concatenation #3900

jeffreykennethli opened this issue Jan 7, 2022 · 0 comments · Fixed by #3901
Assignees
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase

Comments

@jeffreykennethli
Copy link

As seen in this blog post, it's easy to make mistakes when using python implicit string concatenation (5% of repos, including popular ones like tensorflow, v8, pytorch make mistakes related to this). For example:

example_list = [
    "a",
    "b"
    "c"
]
# results in ["a", "bc"]

To avoid this we can try Code Review Doctor (paid) or try this flake8 rule: https://pypi.org/project/flake8-no-implicit-concat/.

@jeffreykennethli jeffreykennethli added the Code Quality 💯 Improvements or issues to improve quality of codebase label Jan 7, 2022
@jeffreykennethli jeffreykennethli self-assigned this Jan 7, 2022
jeffreykennethli pushed a commit to jeffreykennethli/modin that referenced this issue Feb 24, 2022
…contributing docs

Signed-off-by: jeffreykennethli <jkli@ponder.io>
jeffreykennethli pushed a commit to jeffreykennethli/modin that referenced this issue Feb 24, 2022
Signed-off-by: jeffreykennethli <jkli@ponder.io>
YarShev pushed a commit that referenced this issue Feb 25, 2022
…ke8 error codes (#3901)

Signed-off-by: jeffreykennethli <jkli@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase
Projects
None yet
1 participant