REFACTOR-#3900: add flake8-no-implicit-concat plugin and refactor flake8 error codes #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreykennethli
force-pushed
the
patch-1
branch
2 times, most recently
from
c78bf7e
to
eca6307
Compare
jeffreykennethli
changed the title
jeffreykennethli
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3901 +/- ##
==========================================
+ Coverage 86.71% 89.89% +3.18%
==========================================
Files 201 201
Lines 16800 16800
==========================================
+ Hits 14568 15103 +535
+ Misses 2232 1697 -535
Continue to review full report at Codecov.
|
|
|
|
|
Could you please try adding an implicit concat to this PR and checking whether the CI catches it? |
|
@jeffreykennethli Line 24 in fea2064 We have to add a NIC warning type in the selection as well, to enable warnings from the plugin
|
|
Thanks @dchigarev. I added the NIC error codes and the errors show up now. I noticed we also have flake8-print installed but no error codes specified, so I'll add those too. |
jeffreykennethli
changed the title
scripts/test/examples.py
Outdated
| @@ -15,6 +15,7 @@ | |||
| # noqa: MD02 | |||
| """Function examples for docstring testing.""" | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Why was this empty newline added?
There was a problem hiding this comment.
This was formatted according to black's rules, see https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#empty-lines
There was a problem hiding this comment.
Let's make this change in a different PR.
There was a problem hiding this comment.
Removed this change from this PR.
jeffreykennethli
force-pushed
the
patch-1
branch
from
bfd1d3b
to
552adb4
Compare
mvashishtha
previously approved these changes
Feb 4, 2022
vnlitvinov
previously approved these changes
Feb 9, 2022
jeffreykennethli
dismissed stale reviews from vnlitvinov and mvashishtha
via
89404ce
jeffreykennethli
force-pushed
the
patch-1
branch
from
d41b3a2
to
89404ce
Compare
|
@modin-project/modin-omnisci This needs approval |
Garra1980
previously approved these changes
Feb 23, 2022
YarShev
reviewed
Feb 24, 2022
jeffreykennethli
changed the title
jeffreykennethli
changed the title
jeffreykennethli
force-pushed
the
patch-1
branch
from
0f486f8
to
366018b
Compare
added 14 commits
February 24, 2022 11:15
…contributing docs Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
Signed-off-by: jeffreykennethli <jkli@ponder.io>
jeffreykennethli
force-pushed
the
patch-1
branch
from
366018b
to
0868be1
Compare
YarShev
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
To avoid errors like this one: https://codereviewdoctor.medium.com/5-of-666-python-repos-had-comma-typos-including-tensorflow-and-pytorch-sentry-and-v8-7bc3ad9a1bb7, add a recommendation to use flake8-no-implicit-concat in the contributing docs and add this plugin to the CI.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/developer/architecture.rstis up-to-date