REFACTOR-#1941: move index access from DataFrame.insert to backend #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## master #1942 +/- ##
==========================================
+ Coverage 81.68% 81.70% +0.01%
==========================================
Files 79 79
Lines 9283 9282 -1
==========================================
+ Hits 7583 7584 +1
+ Misses 1700 1698 -2
Continue to review full report at Codecov.
|
|
|
YarShev
requested changes
Aug 24, 2020
| @@ -1898,6 +1898,8 @@ def insert(self, loc, column, value): | |||
| value = value.reindex(self.index) | |||
| else: | |||
| value = list(value) | |||
| else: | |||
| value = [value] * len(self.index) | |||
There was a problem hiding this comment.
I think it's better to leave a value creation with np.full.
There was a problem hiding this comment.
Currently, np.full is used in API layer and here all list-like structures (including np.array) are transformed to list. So I just keep semantics by building a list here.
There was a problem hiding this comment.
Okay, I see. Then you just need to rebase on master in order to rerun tests.
Signed-off-by: ienkovich <ilya.enkovich@intel.com>
|
@ienkovich , thanks, LGTM! |
YarShev
approved these changes
Aug 25, 2020
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
…to backend (modin-project#1942) Signed-off-by: ienkovich <ilya.enkovich@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Avoid index access in API layer when scalar is inserted as a new column.
flake8 modinblack --check modingit commit -s