-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST-#3566: make Indexing benchmarks more representative #3700
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3700 +/- ##
===========================================
- Coverage 85.36% 29.49% -55.88%
===========================================
Files 196 183 -13
Lines 16190 15660 -530
===========================================
- Hits 13821 4619 -9202
- Misses 2369 11041 +8672
Continue to review full report at Codecov.
|
a61347d
to
7172e1f
Compare
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
7172e1f
to
68d857c
Compare
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dchigarev awesome PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Dmitry Chigarev dmitry.chigarev@intel.com
What do these changes do?
Changes indexing ASV benchmarks according to the proposal from #3566. In particular:
slice(None, N, None)
).df.iloc[huge_list_with_numerical_indices]
) use a numpy array instead of a python list.df.iloc[small_list_with_numerical_indices]
).TimeIndexingColumns
benchmarks, measuring selection of columns (unlike existedTimeIndexing
measuring rows selection only).Changes not related to the proposal:
TimeIndexing*
benchmarks for OmniSci and Pandas, now there is a base backend-agnostic benchmark class at theasv_bench/benchmarks/benchmarks.py
. Classes at theasv_bench/benchmarks/omnisci/benchmarks.py
are inherited from the base ones and only overwrite the source of the testing data.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/developer/architecture.rst
is up-to-date