-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR-#4229: remove unused dask_client
global variable in modin\pandas\__init__.py
#4230
Conversation
dask_client
global variable in modin\pandas\__init__.py
Codecov Report
@@ Coverage Diff @@
## master #4230 +/- ##
==========================================
+ Coverage 86.82% 89.83% +3.01%
==========================================
Files 201 201
Lines 16809 16808 -1
==========================================
+ Hits 14594 15100 +506
+ Misses 2215 1708 -507
Continue to review full report at Codecov.
|
…e in modin\pandas\__init__.py Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@@ -67,7 +67,6 @@ def test_top_level_api_equality(): | |||
"os", | |||
"multiprocessing", | |||
"Client", | |||
"dask_client", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anmyachev, could you check this list for other options to be removed? I think we can delete something else.
Signed-off-by: Anatoly Myachev anatoly.myachev@intel.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
dask_client
global variable inmodin\pandas\__init__
#4229docs/development/architecture.rst
is up-to-date